Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add Single.delay overload that delays errors #5616

Merged
merged 1 commit into from
Sep 24, 2017

Conversation

PhilGlass
Copy link
Contributor

Much like #5382, I discovered when trying to fake a slow/flaky backend that Single.delay doesn't delay errors.

This PR adds an overload that does, bringing Single.delay in line with Observable.delay. It also corrects the javadoc for existing overloads (#5409 only updated 1/2).

@codecov
Copy link

codecov bot commented Sep 23, 2017

Codecov Report

Merging #5616 into 2.x will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5616      +/-   ##
============================================
- Coverage     96.27%   96.22%   -0.06%     
+ Complexity     5844     5841       -3     
============================================
  Files           632      632              
  Lines         41473    41476       +3     
  Branches       5745     5746       +1     
============================================
- Hits          39929    39910      -19     
- Misses          617      619       +2     
- Partials        927      947      +20
Impacted Files Coverage Δ Complexity Δ
...activex/internal/operators/single/SingleDelay.java 100% <100%> (ø) 2 <1> (ø) ⬇️
src/main/java/io/reactivex/Single.java 100% <100%> (ø) 134 <3> (+2) ⬆️
.../operators/observable/ObservableFlatMapSingle.java 90.29% <0%> (-5.23%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 92.98% <0%> (-3.51%) 11% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-3.23%) 9% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 61.53% <0%> (-2.57%) 12% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.71% <0%> (-2.42%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.56% <0%> (-2.18%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e33000...8005378. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 milestone Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants