Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix TrampolineScheduler not calling RxJavaPlugins.onSchedule(), add tests for all schedulers. #5747

Conversation

artem-zinnatullin
Copy link
Contributor

Noticed during figuring out how #5734 works.

@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #5747 into 2.x will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5747      +/-   ##
============================================
+ Coverage     96.24%   96.27%   +0.02%     
+ Complexity     5833     5832       -1     
============================================
  Files           634      634              
  Lines         41644    41644              
  Branches       5768     5768              
============================================
+ Hits          40082    40094      +12     
+ Misses          633      616      -17     
- Partials        929      934       +5
Impacted Files Coverage Δ Complexity Δ
...tivex/internal/schedulers/TrampolineScheduler.java 94.87% <100%> (ø) 6 <1> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 84.96% <0%> (-7.85%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 91.89% <0%> (-5.41%) 9% <0%> (-1%)
...rnal/subscribers/SinglePostCompleteSubscriber.java 94.87% <0%> (-5.13%) 14% <0%> (-1%)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
.../internal/operators/flowable/FlowableInterval.java 94.44% <0%> (-2.78%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.71% <0%> (-2.42%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...vex/internal/operators/flowable/FlowableCache.java 92.61% <0%> (-1.35%) 7% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 860e39e...db14b1a. Read the comment docs.

@artem-zinnatullin artem-zinnatullin force-pushed the az/2.x/fix-trampoline-scheduler-RxJavaPlugins.onSchedule branch from 600748c to db14b1a Compare November 30, 2017 02:08
@akarnokd akarnokd merged commit d20b17e into ReactiveX:2.x Nov 30, 2017
@artem-zinnatullin artem-zinnatullin deleted the az/2.x/fix-trampoline-scheduler-RxJavaPlugins.onSchedule branch November 30, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants