Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppendOnlyLinkedArrayList#forEachWhile is not breaking iteration properly #5952

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

mekarthedev
Copy link
Contributor

AppendOnlyLinkedArrayList#forEachWhile(NonThrowingPredicate) was break-ing from inner loop instead of return-ing when predicate returned true.

This caused iteration to continue with items from the next array bucket.

@codecov
Copy link

codecov bot commented Apr 7, 2018

Codecov Report

Merging #5952 into 2.x will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5952      +/-   ##
============================================
- Coverage     98.26%   98.23%   -0.04%     
+ Complexity     6017     6014       -3     
============================================
  Files           656      656              
  Lines         44036    44036              
  Branches       6100     6100              
============================================
- Hits          43273    43257      -16     
- Misses          227      237      +10     
- Partials        536      542       +6
Impacted Files Coverage Δ Complexity Δ
...tivex/internal/util/AppendOnlyLinkedArrayList.java 100% <100%> (ø) 23 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-4.48%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 95.96% <0%> (-3.14%) 59% <0%> (-1%)
...activex/internal/schedulers/ExecutorScheduler.java 97.97% <0%> (-2.03%) 9% <0%> (ø)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-1.64%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-1.39%) 56% <0%> (-1%)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3481424...98a86ac. Read the comment docs.

@akarnokd akarnokd added this to the 2.2 milestone Apr 7, 2018
@akarnokd akarnokd merged commit 9b44404 into ReactiveX:2.x Apr 7, 2018
@mekarthedev mekarthedev deleted the fix-foreachwhile-break branch April 7, 2018 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants