fix(Observable): errors thrown during subscription are now properly s… #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent down error channel - Fixes `Observable.create(fn)` and `new Observable(fn)` such that any error thrown in `fn` on subscription will be sent to the subscriber's error handler. - Fixes a subject test that was relying on the errant behavior. fixes #1833
kwonoj
approved these changes
Jan 29, 2017
jayphelps
approved these changes
Jan 29, 2017
|
Woah, I totally forgot about this one. Sorry guys :-( |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent down error channel
Observable.create(fn)andnew Observable(fn)such that any error thrown infnon subscription will be sent to the subscriber's error handler.fixes #1833
Apologies for letting this one slip for so long, everyone. I thought it had been taken care of ages ago.
Description:
Related issue (if exists):