Merge pull request #2079 from RedHatInsights/revert-2076-require_version

Revert "fix: typo in version check"
RedHatInsights · Oct 14, 2024 · c4934e5 · c4934e5
2 parents b476ae8 + a7e1457
commit c4934e5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/config-utils/src/federated-modules.ts b/packages/config-utils/src/federated-modules.ts
@@ -41,7 +41,7 @@ function hasVersionSpecified(config: { [module: string]: WebpackSharedConfig }):
     requiredVersion: string;
   };
 } {
-  return Object.values(config).every((c) => typeof c.requiredVersion === 'string');
+  return Object.values(config).every((c) => typeof c.version === 'string');
 }
 
 const federatedModules = ({
@@ -76,7 +76,7 @@ const federatedModules = ({
   shared.forEach((dep) => {
     if (!hasVersionSpecified(dep)) {
       const invalidDeps = Object.entries(dep)
-        .filter(([, { requiredVersion }]) => typeof requiredVersion !== 'string')
+        .filter(([, { version }]) => typeof version !== 'string')
         .map(([moduleName]) => moduleName);
       throw new Error('Some of your shared dependencies do not have version specified! Dependencies with no version: ' + invalidDeps);
     }