fix: scale sideMenu labels according to computed font size #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `Verdana` isn't present, the system/browser default serif font would be used instead. Fixes #1180 (comment)
adamaltman
reviewed
Aug 20, 2020
| @@ -16,7 +16,7 @@ export const OperationBadge = styled.span.attrs((props: { type: string }) => ({ | |||
| background-repeat: no-repeat; | |||
| background-position: 6px 4px; | |||
| font-size: 7px; | |||
| font-family: Verdana; // web-safe | |||
| font-family: Verdana, sans-serif; // web-safe | |||
There was a problem hiding this comment.
This is what it looks like for me without it:
RomanHotsiy
approved these changes
Aug 20, 2020
|
This is awesome @wopian 👏 Thanks for the detailed explanation! |
|
Thank you 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1180.
See #1180 (comment) for the
widthchange.See #1180 (comment) for the
font-familychange.Setting units in
pxand(r)emuses the CSS-definedfont-sizeunits (in this case7px) and not the computedfont-size, which means the label size does not scale with the increased minimum font sizes users can set in their browser's settings. Minimum font size is a setting in pretty much every browser on Windows, Linux and MacOS and is likely set toNoneby default (hence why it was not reproducable in #1180)If a user sets the minimum font size above
7px(for example10px) then the label width (a static32px) becomes too short for the text width.The
exunit is supported by Chrome 1+, Edge 12+, Firefox 1+, IE 4+ and Safari 1+.32px9ex7pxfont size and no minimum font size (7pxcomputed)7pxfont size and a minimum font size of10px(10pxcomputed)7pxfont size and a mimimum font size of10px(4K display,7pxcomputed)