Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x-logo alt text support #584

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Add x-logo alt text support #584

merged 2 commits into from
Aug 2, 2018

Conversation

viralanomaly
Copy link
Contributor

@viralanomaly viralanomaly commented Jul 31, 2018 •
edited
Loading

This is to address #546

@coveralls
Copy link

coveralls commented Jul 31, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 80.242% when pulling bfedd6c on viralanomaly:xlogo-alttext into 99bef64 on Rebilly:master.

RomanHotsiy
RomanHotsiy requested changes Aug 1, 2018
View reviewed changes
Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the one minor thing: backgroundColor is camel-case while alt-text is kebab-case.
Please update this PR to use altText.

Thanks!

@viralanomaly
Copy link
Contributor Author

Converted to camelCase.

@RomanHotsiy RomanHotsiy merged commit 568ce74 into Redocly:master Aug 2, 2018
@RomanHotsiy
Copy link
Member

LGTM!
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanHotsiy RomanHotsiy RomanHotsiy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viralanomaly @coveralls @RomanHotsiy