Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct return-type when inline=False #132

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Correct return-type when inline=False #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Correct return type when inline=False 
The plot functions do not return `matplotlib.figure.Figure` instances but `matplotlib.axis.Axis` instances when `inline=False`. Technically, they can also return `matplotlib.axes._subplots.AxesSubplot` instances when we are dealing with subplots, but I have left this out for clarity and since the subplot class inherits from the axis class, making them behave in the same way essentially. If you prefer, I can outline this behaviour in the documentation as well.
  • Loading branch information
@maxmahlke
maxmahlke authored Apr 27, 2021
commit 002e313049522d5893468d612c25d99552e6bf0e
2 changes: 1 addition & 1 deletion CONFIGURATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ If you are not satisfied with these admittedly basic configuration parameters, t
in any way you like using `matplotlib` post-facto.

The best way to do this is to specify `inline=False`, which will cause `missingno` to return the underlying
`matplotlib.figure.Figure` object. Anyone with sufficient knowledge of `matplotlib` operations and [the missingno source code](https://github.com/ResidentMario/missingno/blob/master/missingno/missingno.py)
`matplotlib.axis.Axis` object of the main plot (e.g. only the matrix is returned when plotting the matrix with the sparkline). Anyone with sufficient knowledge of `matplotlib` operations and [the missingno source code](https://github.com/ResidentMario/missingno/blob/master/missingno/missingno.py)
can then tweak the display to their liking. For example, the following code will bump the size of the dendrogram
visualization's y-axis labels up from `20` to `30`:

Expand Down