This repository has been archived by the owner on Dec 3, 2022. It is now read-only.
Massive performance improvements #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely! 😍 |
|
@Rich-Harris this is ready for review. Encoding is only ~20-30% faster. 😭 |
I'll take it! Thanks so much, this LGTM — have released 1.4.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote decoding with a streaming version that processes the mapping character by character (without creating intermediate arrays). On a big source map sample (GL JS), it's 2.6x faster than the current implementation (down from 59ms to 22ms), with smaller memory footprint.
Stand by while I'm working on optimizing encoding as well.
The only caveat is that I'd need to remove the
vlqdependency to be able to inline it optimally.@Rich-Harris are you OK with this direction?