Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making HTTP server optional #2086

Merged
merged 31 commits into from
Oct 10, 2024
Merged

Making HTTP server optional #2086

merged 31 commits into from
Oct 10, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Oct 10, 2024 •
edited
Loading

This feature allows to avoid spinning up HTTP server when only HTTPS one is needed.
It should enable best practices in the establishing secure communication channel.

Changes to ServerConfig type:

  • server prop renamed to http
  • nested props jsonParser, upload, compression, rawParser and beforeRouting moved to the top level
  • all that included into the automated migration (ESLint rule) for v21

@RobinTail RobinTail added enhancement New feature or request breaking Backward incompatible changes labels Oct 10, 2024
@RobinTail RobinTail added this to the v21 milestone Oct 10, 2024
@RobinTail RobinTail changed the base branch from master to make-v21 October 10, 2024 07:47
@RobinTail RobinTail added the documentation Improvements or additions to documentation label Oct 10, 2024
@RobinTail RobinTail mentioned this pull request Oct 10, 2024
Draft
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Oct 10, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 1c47da8 on optional-http-server
into 4c54b45 on make-v21.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Oct 10, 2024
@RobinTail RobinTail added the coverage Additional tests label Oct 10, 2024
@RobinTail RobinTail marked this pull request as ready for review October 10, 2024 16:05
@RobinTail RobinTail mentioned this pull request Oct 10, 2024
Closed
RobinTail
RobinTail commented Oct 10, 2024
View reviewed changes
tests/unit/server.spec.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Oct 10, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit fa2bccf into make-v21 Oct 10, 2024
11 checks passed
@RobinTail RobinTail deleted the optional-http-server branch October 10, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Backward incompatible changes coverage Additional tests documentation Improvements or additions to documentation enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Milestone
v21
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail