Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate calcualteScoresheet into calculateTally and calculateJudgeResult + separate tallyFieldDefinitions #32

Closed
swantzter opened this issue Sep 7, 2024 · 0 comments · Fixed by #30

Comments

@swantzter
Copy link
Member

There are instances for mark scoresheets where the order of marks matter in a way that can't be described in a tally sheet. Or times where there are two different schemas used in the mark scoresheet that is easier understood as one in a tally.

This would place the burden of calculating the tally on the judge model instead of as a global helper function (most could still use the global without modification) and change the order of calculation slightly for library consumers:

mark scoresheet => calculateTally() => calculateJudgeResult() => result
tally scoresheet => calculateJudgeResult() => result

and for converting a mark scoresheet for editing in a scoring system you'd use tallyFieldDefinitions (if present, otherwise use fieldDefinitions) and convert the incoming mark scoresheet with calculateTally()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant