Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate calcualteScoresheet into calculateTally and calculateJudgeResult + separate tallyFieldDefinitions #30

Merged
merged 6 commits into from
Sep 22, 2024

remove ijru@4 rules for now

05239bd
Select commit
Loading
Failed to load commit list.
Merged

separate calcualteScoresheet into calculateTally and calculateJudgeResult + separate tallyFieldDefinitions #30

remove ijru@4 rules for now
05239bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 22, 2024 in 1s

42.88% (-1.43%) compared to 98ff4c3

View this Pull Request on Codecov

42.88% (-1.43%) compared to 98ff4c3

Details

Codecov Report

Attention: Patch coverage is 54.33071% with 116 lines in your changes missing coverage. Please review.

Project coverage is 42.88%. Comparing base (98ff4c3) to head (05239bd).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...b/models/competition-events/svgf-vh.timing@2023.ts 6.06% 31 Missing ⚠️
...odels/competition-events/svgf-vh.freestyle@2023.ts 12.90% 27 Missing ⚠️
.../models/competition-events/ijru.freestyle@2.0.0.ts 20.00% 24 Missing ⚠️
...odels/competition-events/svgf-rh.freestyle@2020.ts 11.11% 24 Missing ⚠️
...ib/models/competition-events/svgf-vh.speed@2023.ts 33.33% 6 Missing ⚠️
lib/models/types.ts 92.00% 2 Missing ⚠️
.../models/competition-events/ijru.freestyle@3.0.0.ts 96.66% 1 Missing ⚠️
lib/models/competition-events/ijru.speed@1.0.0.ts 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   44.31%   42.88%   -1.43%     
==========================================
  Files          17       17              
  Lines        2918     3043     +125     
  Branches       84       90       +6     
==========================================
+ Hits         1293     1305      +12     
- Misses       1620     1736     +116     
+ Partials        5        2       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov