Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure missing #41

Open
emillaurin opened this issue Feb 23, 2023 · 8 comments
Open

Configure missing #41

emillaurin opened this issue Feb 23, 2023 · 8 comments

Comments

@emillaurin
Copy link

It seems like configure is missing

It could just be me, but all instructions that I've found refer to running configure first. e.g., ./configure && make test && sudo make install. I'm not sure how to proceed.

Aside: It would be handy for new users if there was a short paragraph included in the readme on installing rl_json.

@oupfiz5
Copy link

oupfiz5 commented May 1, 2023

I've tried the following command and got errors ( tag 0.12.2).

autoconf
/usr/bin/m4:aclocal.m4:5: cannot open `tclconfig/tcl.m4': No such file or directory
/usr/bin/m4:aclocal.m4:11: cannot open `teabase/teabase.m4': No such file or directory
autom4te-2.60: /usr/bin/m4 failed with exit status: 1

As I understand the archive from tag doesn't contain the necessary files in directories tclconfig and teabase. Could you add them in archives?

@cyanogilvie
Copy link
Member

cyanogilvie commented May 1, 2023 via email

@cyanogilvie
Copy link
Member

configure is a generated file, you need to run autoconf to create it. I've followed the common practice of not checking generated files into the version control history, only the source files that form input into that generation (mostly - the exception in this project is that the stubs info created by make genstubs is committed, following the practice of the Tcl core and similar. make genstubs is an arcane enough step that I felt it was warranted).

It seems like configure is missing

It could just be me, but all instructions that I've found refer to running configure first. e.g., ./configure && make test && sudo make install. I'm not sure how to proceed.

Aside: It would be handy for new users if there was a short paragraph included in the readme on installing rl_json.

@oupfiz5
Copy link

oupfiz5 commented May 1, 2023

Tclconfig is a git submodule, clone the repo recursively to pull in this and the other required submodules

I've extracted files from https://github.com/RubyLane/rl_json/archive/refs/tags/0.12.2.tar.gz . This archive doesn't contain submodules files.

FYI I've compiled from source using following sequence steps (pay attention: I need only release branch (0.12.2) and don't need git history):

git clone --recurse-submodules --depth 1 --branch 0.12.2 https://github.com/RubyLane/rl_json.git rl_json-0.12.2
cd rl_json-0.12.2
autoconf
./configure
./make
./make install

@cyanogilvie
Copy link
Member

cyanogilvie commented May 1, 2023 via email

@oupfiz5
Copy link

oupfiz5 commented May 1, 2023

@cyanogilvie I will try to describe my thoughts more clearly :).

Some time ago I used archive https://github.com/RubyLane/rl_json/archive/refs/tags/0.11.2.tar.gz . It still has directory tclconfig with necessary files. Earlier I could download archive, extract, make autoconf, configure etc. to my Dockerfile. Now I need to upload source code only via git first and after that do autoconf, configure etc. As for me, the earlier procedure when archive contains all files and may be installed from the source directly is much more simple than installation using git (it is only my opinion).

@cyanogilvie
Copy link
Member

cyanogilvie commented May 2, 2023 via email

@emillaurin
Copy link
Author

git fetch with submodules does the trick
(just needed to add sudo for the last make install-binaries install libraries to work on my system)

git clone --recurse-submodules --shallow-submodules --branch 0.12.2 --single-branch --depth 1 https://github.com/RubyLane/rl_json
autoconf && ./configure CFLAGS="${CFLAGS}" --enable-symbols && make -j 8 all && sudo make install-binaries install-libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants