Implement SerializeBytes for TlsByteVecUX types
#1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imor
changed the title
TlsByteVecUX typesSerializeBytes for TlsByteVecUX types
This was referenced Jul 2, 2023
imor
force-pushed
the
impl_serialize_bytes_for_vecs
branch
from
9c745bd
to
0c23e29
Compare
franziskuskiefer
requested changes
Jul 4, 2023
tls_codec/src/tls_vec.rs
Outdated
| @@ -78,6 +78,45 @@ macro_rules! impl_byte_deserialize { | |||
| let result = Self { vec: vec.to_vec() }; | |||
| Ok((result, &remainder.get(len..).ok_or(Error::EndOfStream)?)) | |||
| } | |||
|
|
|||
| fn serialize_bytes_bytes(&$self) -> Result<Vec<u8>, Error> { | |||
There was a problem hiding this comment.
This looks like a lot of duplicate code. Can you factor out some of it to reuse as much as possible?
|
Bump, @franziskuskiefer could you please review the changes. |
|
@franziskuskiefer the changes you requested have been done, could you please review this PR. |
franziskuskiefer
requested changes
Jul 21, 2023
| tls_serialized_len, written | ||
| ); | ||
| if written != tls_serialized_len { | ||
| return Err(Error::EncodingError(format!( |
There was a problem hiding this comment.
Why did you remove this check in assert_written_bytes?
There was a problem hiding this comment.
This check is present in the assert_written_bytes function: see line 191 in the new file.
Co-authored-by: Franziskus Kiefer <franziskuskiefer@gmail.com>
franziskuskiefer
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
SerializeBytestrait for all theTlsByteVecUXtypes. It also adds tests for serializing them using theSerializeBytestrait.