Remove proc-macro-error dependency #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
reviewed
Aug 2, 2023
| @@ -121,6 +121,12 @@ | |||
| unused_qualifications | |||
| )] | |||
|
|
|||
| macro_rules! abort { | |||
There was a problem hiding this comment.
This got me confused for a minute. I was wondering where abort was coming from since you were deleting proc-macro-error.
baloo
approved these changes
Aug 2, 2023
tarcieri
approved these changes
Aug 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1173.
I chose to minimize the diff by introducing a minimal
abort!macro that early-returns likeanyhow::bail!or similar macros, which reduces the amount of code that has to change a lot.Further refactorings are possible (in particular, I personally prefer to collect all attribute errors and emitting them individually where possible, instead of short-circuiting on the first error), but I didn't do any of that in this PR for the same reason. Let me know if you're interested in anything like that.