Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkcs5: downstream api changes #1196

Conversation

baloo
Copy link
Member

@baloo baloo commented Aug 9, 2023

No description provided.

Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
@baloo baloo marked this pull request as ready for review August 9, 2023 16:59
@baloo baloo changed the base branch from master to pkcs5/remove-lifetimes August 9, 2023 16:59
@tarcieri
Copy link
Member

tarcieri commented Aug 9, 2023

@baloo we might need to bump the pkcs5 version to 0.8.0-pre for the minimal-versions check to pass

Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
@baloo
Copy link
Member Author

baloo commented Aug 9, 2023

I don't think that's enough, and pkcs5 0.8.0-pre will need to be published to crates.io
With #997 I've put the overrides on the top /Cargo.toml with a [patch.crates-io] block. This gets removed when minimal-versions runs.

@tarcieri
Copy link
Member

Okay, I guess it’s fine to temporarily disable then

Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
@tarcieri tarcieri merged commit ebe2b2c into RustCrypto:pkcs5/remove-lifetimes Aug 10, 2023
172 checks passed
@baloo baloo deleted the baloo/pkcs5/downstream-api-changes branch August 11, 2023 20:49
tarcieri pushed a commit that referenced this pull request Aug 28, 2023
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
tarcieri pushed a commit that referenced this pull request Jan 7, 2024
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
tarcieri pushed a commit that referenced this pull request Jan 7, 2024
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants