Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

const-oid: fix large arc handling in encoder #1522

Merged
merged 2 commits into from
Sep 18, 2024
Merged

const-oid: fix large arc handling in encoder #1522

merged 2 commits into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. const-oid: fix large arc handling in encoder 

    BER encodings were being miscomputed for certain large arcs.

The previous method was a bit wacky (in addition to being buggy) and
attempted to encode each arc backwards within the BER output buffer.

This switches to a new method which splits the upper 7 bits from an arc
and encodes that as a byte, continuing until all bytes of the arc have
been encoded, which is much more straightforward.

The problematic cases which were reported have now been corrected.

Fixes #1520
    @tarcieri
    tarcieri committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    30d3852 View commit details
    Browse the repository at this point in the history

  2. clippy

    @tarcieri
    tarcieri committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7dcedc8 View commit details
    Browse the repository at this point in the history