fix assertWithinTolerance

It was not actually checking anything.
Rvdixit23 · Jan 14, 2020 · ea66cf3 · ea66cf3
1 parent 7f4d5e3
commit ea66cf3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -78,3 +78,6 @@ Antonio Larrosa
 
 Aaron Craig
     github: craigthelinguist
+
+Carlos del Castillo
+    github: greyalien502
diff --git a/test/test.py b/test/test.py
@@ -141,9 +141,9 @@ def assertWithinRange(self, val, lower_bound, upper_bound):
         def assertWithinTolerance(self, val, expected, tolerance=None,
                                   percentage=None):
             if percentage is not None:
-                tolerance = val * percentage
-            lower_bound = val - tolerance
-            upper_bound = val + tolerance
+                tolerance = expected * percentage
+            lower_bound = expected - tolerance
+            upper_bound = expected + tolerance
             self.assertWithinRange(val, lower_bound, upper_bound)
 
         def test_export_pathlib_path(self):
@@ -217,9 +217,9 @@ def assertWithinRange(self, val, lower_bound, upper_bound):
     def assertWithinTolerance(self, val, expected, tolerance=None,
                               percentage=None):
         if percentage is not None:
-            tolerance = val * percentage
-        lower_bound = val - tolerance
-        upper_bound = val + tolerance
+            tolerance = expected * percentage
+        lower_bound = expected - tolerance
+        upper_bound = expected + tolerance
         self.assertWithinRange(val, lower_bound, upper_bound)
 
     def test_direct_instantiation_with_bytes(self):