bug fix on account page (Uniswap#327)

* bug fix on account page * Fix code style issues with ESLint Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
RyoshiShibbone · Dec 20, 2020 · 932efce · 932efce
1 parent 11309c0
commit 932efce
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/src/components/MiningPositionList/index.js b/src/components/MiningPositionList/index.js
@@ -205,8 +205,8 @@ function MiningPositionList({ miningPositions }) {
 
       .sort((p0, p1) => {
         if (sortedColumn === SORT_FIELD.VALUE) {
-          const bal0 = (p0.balance / p0.pairData.totalSupply) * p0.pairData.reserveUSD
-          const bal1 = (p0.balance / p0.pairData.totalSupply) * p1.pairData.reserveUSD
+          const bal0 = (p0.balance / p0.pairData?.totalSupply) * p0.pairData?.reserveUSD
+          const bal1 = (p0.balance / p0.pairData?.totalSupply) * p1.pairData?.reserveUSD
           return bal0 > bal1 ? (sortDirection ? -1 : 1) : sortDirection ? 1 : -1
         }
         return 1

diff --git a/src/contexts/User.js b/src/contexts/User.js
@@ -415,12 +415,16 @@ export function useUserLiquidityChart(account) {
 
         // now cycle through pair day datas, for each one find usd value = ownership[address] * reserveUSD
         const dailyUSD = relavantDayDatas.reduce((totalUSD, dayData) => {
-          return (totalUSD =
-            totalUSD +
-            (ownershipPerPair[dayData.pairAddress]
-              ? (parseFloat(ownershipPerPair[dayData.pairAddress].lpTokenBalance) / parseFloat(dayData.totalSupply)) *
-                parseFloat(dayData.reserveUSD)
-              : 0))
+          if (dayData) {
+            return (totalUSD =
+              totalUSD +
+              (ownershipPerPair[dayData.pairAddress]
+                ? (parseFloat(ownershipPerPair[dayData.pairAddress].lpTokenBalance) / parseFloat(dayData.totalSupply)) *
+                  parseFloat(dayData.reserveUSD)
+                : 0))
+          } else {
+            return totalUSD
+          }
         }, 0)
 
         formattedHistory.push({