feat: How to add a third party module #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
longieirl
commented
Dec 14, 2023
longieirl
commented
- Append a new sample project showing the introduction of a third party module i.e. xml-js
docirl
approved these changes
Dec 15, 2023
|
@ashleytung can you please review, thanks. |
longieirl
changed the title
ashleytung
requested changes
Jan 5, 2024
thirdpartylibrary/README.md
Outdated
| - Sub-account destination `northwind` is available, please see attached `northind` configuration | ||
|
|
||
| # Sample Project | ||
| A [Fiori tools Freestyle UI application](./ztravelapp/README.md) with an external library `xml-js` enabled. |
There was a problem hiding this comment.
freestyle app should be referred to as freestyle SAPUI5 app. Also, I suggest to make the sentence a bit more descriptive. Example: "This freestyle SAPUI5 application demonstrates how to add an external library xml-js to the project"
| @@ -0,0 +1,66 @@ | |||
| # Adding External Library to your Fiori UI application | |||
There was a problem hiding this comment.
SAP Fiori instead of Fiori
|
|
||
| From your SAP BTP cockpit, select Instances and Subscriptions, select SAP Business Application Studio which will open a new tab into your dev space manager. Generate a SAP Fiori dev space. | ||
|
|
||
| # Generate a Fiori UI Freestyle Application |
There was a problem hiding this comment.
"freestyle SAPUI5 application"
changed from "Fiori" to "SAP Fiori"
ashleytung
approved these changes
Jan 5, 2024
Can you please merge as I dont have access? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.