fix: [HCPSDKFIORIUIKIT-2043] resolve UIFont instance from Swift pass to SwiftUI can't be resized and empty text disable accessibility. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to SwiftUI can't be resized and empty text disable accessibility.
|
|
billzhou0223
requested changes
Apr 20, 2022
| @@ -143,7 +143,13 @@ class LayoutData { | |||
| let title = item.text | |||
| var uifont: UIFont | |||
| if let tmpUIFont = item.uifont { | |||
| uifont = tmpUIFont | |||
| // `item.uifont` is passed by developer, although is a preferred font but can't resize according to system in SwiftUI. So need to redefine the UIFont instance. | |||
| if let styleName = tmpUIFont.fontDescriptor.fontAttributes[.textStyle] as? String { | |||
There was a problem hiding this comment.
In order for the text to be resizable, developes are responsible for passing in a scaled font. We, as SDK, are not supposed to force this conversion.
There was a problem hiding this comment.
At now, the issue is developers had init a UIFont instance via UIFont.preferredFont() in SDK and passed it to SwiftUI, but the text doesn't be resizable in SwiftUI. In order to fix the issue, so need to redefine UIFont in SwiftUI, it is as the above code.
shengxu7
approved these changes
Apr 21, 2022
billzhou0223
approved these changes
Apr 21, 2022
|
When it can be merged into the main branch? Whether this pull request has any question? Because I need to fix the issue-2043. |
AllenCao001
added a commit
to AllenCao001/cloud-sdk-ios-fiori
that referenced
this pull request
Apr 27, 2022
…to SwiftUI can't be resized and empty text disable accessibility. (SAP#418) Co-authored-by: Bill Zhou <bill.zhou01@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.