feat: 🎸 [jira: 2572] new card footer for Joule Object Card #706
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| for (i, subview) in subviews.enumerated() { | ||
| let x = cache.frames[i].origin.x + bounds.minX | ||
| let y = cache.frames[i].origin.y + bounds.minY | ||
| subview.place(at: CGPointMake(x, y), |
There was a problem hiding this comment.
Legacy Constructor Violation: Swift constructors are preferred over legacy convenience functions. (legacy_constructor)
|
|
||
| /// .compact, .sameAndFill, same size, up to 2 buttons | ||
| /// .reguar, .intrinsic, up to 3 buttons | ||
| func calculateLayout(proposalWidth: CGFloat?, subViewSizes: [CGSize], hideRect: CGRect, layoutMode: LayoutMode, cache: inout CacheData) { |
There was a problem hiding this comment.
Cyclomatic Complexity Violation: Function should have complexity 10 or less: currently complexity equals 15 (cyclomatic_complexity)
Function Body Length Violation: Function body should span 60 lines or less excluding comments and whitespace: currently spans 70 lines (function_body_length)
| for (i, subview) in subviews.enumerated() { | ||
| let x = cache.frames[i].origin.x + bounds.minX | ||
| let y = cache.frames[i].origin.y + bounds.minY | ||
| subview.place(at: CGPointMake(x, y), |
There was a problem hiding this comment.
Legacy Constructor Violation: Swift constructors are preferred over legacy convenience functions. (legacy_constructor)
|
|
||
| /// .compact, .sameAndFill, same size, up to 2 buttons | ||
| /// .reguar, .intrinsic, up to 3 buttons | ||
| func calculateLayout(proposalWidth: CGFloat?, subViewSizes: [CGSize], hideRect: CGRect, layoutMode: LayoutMode, cache: inout CacheData) { |
There was a problem hiding this comment.
Cyclomatic Complexity Violation: Function should have complexity 10 or less: currently complexity equals 15 (cyclomatic_complexity)
Function Body Length Violation: Function body should span 60 lines or less excluding comments and whitespace: currently spans 70 lines (function_body_length)
|
|
||
| /// Sample cards for testing | ||
| public static let cardSamples = [sampleCard1, sampleCard13, sampleCard2, sampleCard3, sampleCard4, sampleCard5, sampleCard6, sampleCard7, sampleCard9, sampleCard10, vbCard, sampleCard11, sampleCard8, fullCard] | ||
| public static let cardFooterSamples = [sampleCard6, sampleCard16, sampleCard17, sampleCard12, sampleCard13, sampleCard14, sampleCard15, sampleCard20, sampleCard18, sampleCard19] |
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
| for (i, subview) in subviews.enumerated() { | ||
| let x = cache.frames[i].origin.x + bounds.minX | ||
| let y = cache.frames[i].origin.y + bounds.minY | ||
| subview.place(at: CGPointMake(x, y), |
There was a problem hiding this comment.
Legacy Constructor Violation: Swift constructors are preferred over legacy convenience functions. (legacy_constructor)
|
|
||
| /// .compact, .sameAndFill, same size, up to 2 buttons | ||
| /// .reguar, .intrinsic, up to 3 buttons | ||
| func calculateLayout(proposalWidth: CGFloat?, subViewSizes: [CGSize], hideRect: CGRect, layoutMode: LayoutMode, cache: inout CacheData) { |
There was a problem hiding this comment.
Cyclomatic Complexity Violation: Function should have complexity 10 or less: currently complexity equals 15 (cyclomatic_complexity)
Function Body Length Violation: Function body should span 60 lines or less excluding comments and whitespace: currently spans 70 lines (function_body_length)
| for (i, subview) in subviews.enumerated() { | ||
| let x = cache.frames[i].origin.x + bounds.minX | ||
| let y = cache.frames[i].origin.y + bounds.minY | ||
| subview.place(at: CGPointMake(x, y), |
There was a problem hiding this comment.
Legacy Constructor Violation: Swift constructors are preferred over legacy convenience functions. (legacy_constructor)
|
|
||
| /// .compact, .sameAndFill, same size, up to 2 buttons | ||
| /// .reguar, .intrinsic, up to 3 buttons | ||
| func calculateLayout(proposalWidth: CGFloat?, subViewSizes: [CGSize], hideRect: CGRect, layoutMode: LayoutMode, cache: inout CacheData) { |
There was a problem hiding this comment.
Cyclomatic Complexity Violation: Function should have complexity 10 or less: currently complexity equals 15 (cyclomatic_complexity)
Function Body Length Violation: Function body should span 60 lines or less excluding comments and whitespace: currently spans 70 lines (function_body_length)
|
|
||
| /// Sample cards for testing | ||
| public static let cardSamples = [sampleCard1, sampleCard13, sampleCard2, sampleCard3, sampleCard4, sampleCard5, sampleCard6, sampleCard7, sampleCard9, sampleCard10, vbCard, sampleCard11, sampleCard8, fullCard] | ||
| public static let cardFooterSamples = [sampleCard6, sampleCard16, sampleCard17, sampleCard12, sampleCard13, sampleCard14, sampleCard15, sampleCard20, sampleCard18, sampleCard19] |
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
| import Foundation | ||
| import SwiftUI | ||
|
|
||
| /** |
There was a problem hiding this comment.
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)
| for (i, subview) in subviews.enumerated() { | ||
| let x = cache.frames[i].origin.x + bounds.minX | ||
| let y = cache.frames[i].origin.y + bounds.minY | ||
| subview.place(at: CGPointMake(x, y), |
There was a problem hiding this comment.
Legacy Constructor Violation: Swift constructors are preferred over legacy convenience functions. (legacy_constructor)
|
|
||
| /// .compact, .sameAndFill, same size, up to 2 buttons | ||
| /// .reguar, .intrinsic, up to 3 buttons | ||
| func calculateLayout(proposalWidth: CGFloat?, subViewSizes: [CGSize], hideRect: CGRect, layoutMode: LayoutMode, cache: inout CacheData) { |
There was a problem hiding this comment.
Cyclomatic Complexity Violation: Function should have complexity 10 or less: currently complexity equals 15 (cyclomatic_complexity)
Function Body Length Violation: Function body should span 60 lines or less excluding comments and whitespace: currently spans 70 lines (function_body_length)
|
|
||
| /// Sample cards for testing | ||
| public static let cardSamples = [sampleCard1, sampleCard13, sampleCard2, sampleCard3, sampleCard4, sampleCard5, sampleCard6, sampleCard7, sampleCard9, sampleCard10, vbCard, sampleCard11, sampleCard8, fullCard] | ||
| public static let cardFooterSamples = [sampleCard6, sampleCard16, sampleCard17, sampleCard12, sampleCard13, sampleCard14, sampleCard15, sampleCard20, sampleCard18, sampleCard19] |
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
| import Foundation | ||
| import SwiftUI | ||
|
|
||
| /** |
There was a problem hiding this comment.
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)
| import Foundation | ||
| import SwiftUI | ||
|
|
||
| /** |
There was a problem hiding this comment.
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)
* feat: 🎸 [jira: 2572] new card footer for Joule Object Card * fix: 🐛 [jira: 2572] change the backgroud of popup in footer
No description provided.