TST: run tests in docker image + fix setup.cfg regression #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds the main docker image, runs the pytests in it, and runs a sample image through wsinfer in the docker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 'test-docker' step to CI. And fixes the path to package_data in setup.cfg.
During the creation of this PR I discovered that the 0.3.2 release wheel will not work because the tcga.csv file is not present (because package_data was not changed when I made patchlib into _patchlib). So after this PR is merged, we should release a new version and remove 0.3.2 from pypi. but the docker images work fine, so we can leave those alone. i added the 'test-package' job in ci to catch regressions in the python package. running wsinfer from a different directory (and from a non-editable install) triggered the error.