Feature/weather #47
Merged
Feature/weather #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this, amazing ❤️ |
|
Not a problem, everywhere It has been added location( |
SEAbdulbasit
reviewed
Mar 3, 2024
shared/src/commonMain/kotlin/com/example/travelapp_kmp/listing/ListScreenViewModel.kt
Outdated
Show resolved
Hide resolved
SEAbdulbasit
reviewed
Mar 3, 2024
SEAbdulbasit
reviewed
Mar 3, 2024
Amazing man, the file was not rendered in the browser, so I missed it. Just thinking about if the weather fetching is async or not because we don't want the use to stuck in switch tourist places. |
SEAbdulbasit
reviewed
Mar 3, 2024
shared/src/commonMain/kotlin/com/example/travelapp_kmp/listing/MainScreen.kt
Outdated
Show resolved
Hide resolved
SEAbdulbasit
requested changes
Mar 14, 2024
shared/src/commonMain/kotlin/com/example/travelapp_kmp/listing/ListScreenState.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/com/example/travelapp_kmp/listing/ListScreenState.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/com/example/travelapp_kmp/listing/ListScreenState.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/com/example/travelapp_kmp/listing/ListScreenViewModel.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/com/example/travelapp_kmp/listing/ListScreenViewModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Abdul Basit <33172684+SEAbdulbasit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use openweathermap api to get weather state using ktor and use coil3 to show image weather and change fake data weather state to real depend on city.
Not: don't forget get API key openweathermap and put.