Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sf::Vulkan functions #198

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Implement sf::Vulkan functions #198

merged 1 commit into from
Jul 6, 2023

Conversation

ChrisThrasher
Copy link
Member

Implements SFML/SFML#1557

@ChrisThrasher ChrisThrasher force-pushed the vulkan branch 2 times, most recently from 22bd6a1 to f39fe00 Compare July 5, 2023 04:00
shane-tran-whitmire
shane-tran-whitmire approved these changes Jul 5, 2023
View reviewed changes
Copy link

@shane-tran-whitmire shane-tran-whitmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my work account. You can consider this a regular approval

@shane-tran-whitmire shane-tran-whitmire mentioned this pull request Jul 5, 2023
Open
6 tasks
eXpl0it3r
eXpl0it3r requested changes Jul 6, 2023
View reviewed changes
src/SFML/Window/Vulkan.cpp Outdated Show resolved Hide resolved
@ChrisThrasher ChrisThrasher merged commit 2a20bc7 into master Jul 6, 2023
10 checks passed
@ChrisThrasher ChrisThrasher deleted the vulkan branch July 6, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eXpl0it3r eXpl0it3r eXpl0it3r approved these changes

@kimci86 kimci86 kimci86 approved these changes

@shane-tran-whitmire shane-tran-whitmire shane-tran-whitmire approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisThrasher @eXpl0it3r @kimci86 @shane-tran-whitmire