Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API for sf::WindowBase #207

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Add API for sf::WindowBase #207

merged 1 commit into from
Nov 19, 2023

Conversation

ChrisThrasher
Copy link
Member

@ChrisThrasher ChrisThrasher commented Nov 2, 2023 •
edited
Loading

Depends on #206

@ChrisThrasher ChrisThrasher mentioned this pull request Nov 2, 2023
Closed
@ChrisThrasher ChrisThrasher marked this pull request as ready for review November 2, 2023 15:19
@Marioalexsan
Copy link
Member

The code is missing a binding for createVulkanHandle.

@ChrisThrasher
Copy link
Member Author

The code is missing a binding for createVulkanHandle.

Thanks, should be done now

eXpl0it3r
eXpl0it3r requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, then this should be ready to go

include/SFML/Window/WindowBase.h Outdated Show resolved Hide resolved
include/SFML/Window/WindowBase.h Outdated Show resolved Hide resolved
src/SFML/Window/WindowBase.cpp Outdated Show resolved Hide resolved
src/SFML/Window/WindowBase.cpp Outdated Show resolved Hide resolved
include/SFML/Window/Vulkan.h Show resolved Hide resolved
@eXpl0it3r eXpl0it3r merged commit e240141 into master Nov 19, 2023
14 checks passed
@eXpl0it3r eXpl0it3r deleted the window_base branch November 19, 2023 12:23
@eXpl0it3r eXpl0it3r mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eXpl0it3r eXpl0it3r eXpl0it3r approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisThrasher @Marioalexsan @eXpl0it3r