check malloc return value for NULL and update docs #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZXShady
force-pushed
the
check_malloc_return_value
branch
2 times, most recently
from
3ebcabc
to
91b499e
Compare
`sfFtpDirectoryResponse_getDirectory` can fail and return NULL becuase 'strdup' returns null on failure but `sfFtpDirectoryResponse_getDirectoryUnicode` didn't and just had UB due not checking return value of malloc. typing NULL in the docs made me age 30 years btw
ZXShady
force-pushed
the
check_malloc_return_value
branch
from
91b499e
to
0efbfe0
Compare
ChrisThrasher
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sfFtpDirectoryResponse_getDirectorycan fail and return NULL becuase 'strdup' returns null on failure and it didn't mention it in the docs butsfFtpDirectoryResponse_getDirectoryUnicodedidn't and just had UB due not checking return value of malloc.typing
NULLinstead ofnullptrin the docs made me age 30 years btw