Make enumeration counts constant expressions #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows now having these variables as array sizes that are not Variable Length Arrays like in structs for example.
To note however that this changes the type from unsigned int to an implementation defined type which usually
int
which is signed and not unsigned. and also disallows taking the address of the constant since it is mo longer a variable.the other is using a macro which I don't like, but it can allow us to change the type to an unsigned type if we really wanted
but I prefer CSFML to be macro free if possible so I choose the enum approach.