Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unable to build SFML with latest Android NDK #1575

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

acsbendi
Copy link
Contributor

@acsbendi acsbendi commented Apr 8, 2019

Thanks a lot for making a contribution to SFML! 🙂

Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)

  • Has this change been discussed on the forum or in an issue before?
  • Does the code follow the SFML Code Style Guide?
  • Have you provided some example/test code for your changes?
  • If you have additional steps which need to be performed list them as tasks!

Description

SFML could not be built using the latest NDK, since CMake did not find any libraries (such as OpenAL).
This PR will fix this.
The problem was caused by the the changes added in NDK r19b. Since then, NDK adds its root path to CMAKE_FIND_ROOT_PATH. To tell CMake to also search for the libraries in SFML's directory, we have to add it to CMAKE_FIND_ROOT_PATH too.

Tasks

  • Tested on Linux
  • Tested on Windows
  • Tested on macOS
  • Tested on iOS
  • Tested on Android

How to test this PR?

Try to build SFML using the latest (r19c) Android NDK. Without this PR, it will fail.

@auzden
Copy link

auzden commented Apr 11, 2019

This worked for me on NDK r19c on Windows 10. Many thanks!

@acsbendi
Copy link
Contributor Author

@auzden You're welcome :)

CMakeLists.txt Outdated Show resolved Hide resolved
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Aug 12, 2021
@eXpl0it3r eXpl0it3r merged commit 4135855 into SFML:master Aug 12, 2021
@eXpl0it3r
Copy link
Member

Thanks for this! 🙂

Sorry it took so long 😓

@acsbendi
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants