-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected/clarified the setLoopPoints() documentation #2083
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.6.x #2083 +/- ##
=======================================
Coverage ? 8.92%
=======================================
Files ? 185
Lines ? 15874
Branches ? 4190
=======================================
Hits ? 1416
Misses ? 14326
Partials ? 132 Continue to review full report at Codecov.
|
I want to target the 2.6.x branch too. Should I rebase this pull req? |
PRs can only target a single branch. If you want to merge this into 2.6.x and master the you'll have to make 2 PRs, but don't do that until the first is merged. |
Alternatively, you can rebase this PR onto |
The previous documentation talks about 'end points' but the current code does not take end point as an argument and hence does not allow specifying the end point of the loop. (Instead the functions allows specifying the beginning offset and the length of the loop.)
Successfully changed the base of this PR to |
Thank you for making the documentation clearer 🙂 |
The previous documentation talks about 'end points' but the current code does not take end point as an argument and hence does not allow specifying the end point of the loop. (Instead the functions allows specifying the beginning offset and the length of the loop.)
Thanks a lot for making a contribution to SFML! 🙂
Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)
Description
Please describe your pull request.
This PR is related to the issue #
Tasks
How to test this PR?
Describe how to best test these changes. Please provide a minimal, complete and verifiable example if possible, you can use the follow template as a start: