Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eglCheck macro usage for assignments #2146

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Fix eglCheck macro usage for assignments #2146

merged 1 commit into from
Jun 24, 2022

Conversation

kimci86
Copy link
Contributor

@kimci86 kimci86 commented Jun 23, 2022

Description

Compiling SFML on branch 2.6.x with option SFML_USE_DRM=True fails in debug mode.
This patch fixes the compilation errors.

How to test this PR?

cmake -B build -DCMAKE_BUILD_TYPE=Debug -DSFML_USE_DRM=True
cmake --build build

Tested on Ubuntu and Raspbian.

@kimci86 kimci86 mentioned this pull request Jun 23, 2022
Merged
@eXpl0it3r eXpl0it3r added this to the 2.6 milestone Jun 24, 2022
@eXpl0it3r eXpl0it3r merged commit 5098b6c into SFML:2.6.x Jun 24, 2022
@eXpl0it3r
Copy link
Member

Thanks for this fix! 🙂

@kimci86 kimci86 deleted the bugfix/eglcheck_assignments branch June 26, 2022 21:47
@dogunbound dogunbound mentioned this pull request May 17, 2023
Merged
@ChrisThrasher ChrisThrasher mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binary1248 binary1248 binary1248 approved these changes

Assignees
No one assigned
Labels
bug m:sfml-window p:linux
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@kimci86 @eXpl0it3r @binary1248