Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/molecule/carousel): follow the sui agreements #2456

Merged
merged 1 commit into from
Nov 3, 2022
Merged

fix(components/molecule/carousel): follow the sui agreements #2456

merged 1 commit into from
Nov 3, 2022

Conversation

andresin87
Copy link
Member

molecule/carousel

πŸ” Show

TASK:

Types of changes

  • πŸͺ² Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • πŸ“· Demo
  • πŸ§ͺ Test
  • 🧠 Refactor
  • πŸ’„ Styles

Description, Motivation and Context

Screenshots - Animations

@andresin87 andresin87 self-assigned this Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0.1↓ ≍ 0＝ ≍ 0.09↓ ≍ 0.09↓
% 71.48 58.02 59.23 73.18
ABS 2785 / 3896 1595 / 2749 513 / 866 2680 / 3662

@andresin87 andresin87 merged commit 28e2a51 into master Nov 3, 2022
@andresin87 andresin87 deleted the feat/molecule-carousel branch November 3, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Javier1177 Javier1177 Javier1177 approved these changes

@kikoruiz kikoruiz Awaiting requested review from kikoruiz kikoruiz is a code owner

@rmoralp rmoralp Awaiting requested review from rmoralp

@sui-bot sui-bot Awaiting requested review from sui-bot sui-bot is a code owner

@arnau-rius arnau-rius Awaiting requested review from arnau-rius

Assignees

@andresin87 andresin87

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresin87 @Javier1177