feat(components/atom/tag): Customize background for close icon #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olor for the AtomTag
manjarcode
requested review from
kikoruiz,
andresin87,
rmoralp,
sui-bot,
arnau-rius and
andresz1
as code owners
|
andresin87
approved these changes
Nov 10, 2022
beatrizip
reviewed
Nov 10, 2022
| @@ -206,6 +209,7 @@ $base-class: '.sui-AtomTag'; | |||
| fill: $c; | |||
|
|
|||
| &#{$self}-actionable { | |||
| border: 1px solid; | |||
There was a problem hiding this comment.
Suggested change
| border: 1px solid; | |
| border: $bdw-s solid; |
There was a problem hiding this comment.
I missed this one! it was only for testing I will remove it!
beatrizip
reviewed
Nov 10, 2022
beatrizip
reviewed
Nov 10, 2022
beatrizip
reviewed
Nov 10, 2022
beatrizip
reviewed
Nov 10, 2022
beatrizip
reviewed
Nov 10, 2022
jcger
approved these changes
Nov 10, 2022
beatrizip
approved these changes
Nov 10, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to customize the close icon background and color when mouse hover
Category/Component
❓ AskTASK: https://jira.scmspain.com/browse/PI-52232
Types of changes
Description, Motivation and Context
In jobs we want to customize the close icon hover color to improve the UX
https://www.figma.com/file/x80a9OA3Q6bk182smlfZsl/CV_Refactor?node-id=2002%3A334&t=RsscI4T8ihl0YsBp-0
Screenshots - Animations
We want to customize this default close icon color
According to this we want to customize this default close icon background color (when hover)
The custom type config for the icon color
The custom type config for the icon background (when hover)
