Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/molecule/autosuggest): call on blur after typing #2464

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix(components/molecule/autosuggest): call on blur after typing #2464

merged 1 commit into from
Nov 15, 2022

Conversation

alfdocimo
Copy link
Contributor

@alfdocimo alfdocimo commented Nov 14, 2022 •
edited
Loading

molecule/autosuggest

TASK: #2463

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles

Description, Motivation and Context

Onblur not being called after typing and/or selecting an option

Screenshots - Animations

@github-actions
Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ ≍ 0.62↑ ≍ 0.55↑ ≍ 0.46↑ ≍ 0.46↑
% 73.05 59.28 60.94 74.82
ABS 2849 / 3900 1632 / 2753 529 / 868 2743 / 3666

giodelabarrera
giodelabarrera approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@giodelabarrera giodelabarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽

@alfdocimo alfdocimo merged commit 3207d9d into master Nov 15, 2022
@alfdocimo alfdocimo deleted the fix/#2463-onblur-not-called-after-typing branch November 15, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giodelabarrera giodelabarrera giodelabarrera approved these changes

@andresin87 andresin87 andresin87 approved these changes

@kikoruiz kikoruiz Awaiting requested review from kikoruiz kikoruiz is a code owner

@rmoralp rmoralp Awaiting requested review from rmoralp

@sui-bot sui-bot Awaiting requested review from sui-bot sui-bot is a code owner

@arnau-rius arnau-rius Awaiting requested review from arnau-rius

@andresz1 andresz1 Awaiting requested review from andresz1 andresz1 is a code owner

Assignees

@alfdocimo alfdocimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfdocimo @giodelabarrera @andresin87