feat(packages/sui-react-web-vitals): improve LCP and INP reporting #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordevo
requested review from
sui-bot,
kikoruiz,
andresz1 and
carlosvillu
as code owners
nucliweb
approved these changes
Aug 3, 2023
nucliweb
reviewed
Aug 3, 2023
andresz1
reviewed
Aug 4, 2023
jordevo
changed the title
jordevo
changed the title
…te for CWV_THRESHOLDS
…d when collecting data via mush
andresz1
reviewed
Aug 4, 2023
andresz1
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding necessary features so that
reportAllChanges: truecan be configured for specific metrics, which provides more fine-grained data about CWV metrics. By default, setting it forLCPandINP. Also, by importing theweb-vitals/attributionbuild, we're also able to collect the elements of the page related to the recorded performance metrics.Enabling custom thresholds for metrics via props to allow for fine-tuning of performance metrics, reduce noise on reporting or simply go with Google's defined thresholds for CWV.
Related Issue
n/a
Example