-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(packages/sui-decorators): Create AsyncInlineError decorator #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oriolpuig
requested review from
sui-bot,
kikoruiz,
andresz1 and
carlosvillu
as code owners
March 27, 2024 11:19
carlosvillu
approved these changes
Mar 27, 2024
marcbenito
force-pushed
the
poc/create_new_async_inline_error
branch
from
May 29, 2024 08:42
4616cab
to
dc9b3c3
Compare
oriolpuig
commented
Jun 3, 2024
…eError and mark method warning
…ust exist fix suggestion
…der with fix suggestion
…rror() on services and reposito
…n instead of ClassDefinition
…ne-error and manage rule by pat
oriolpuig
force-pushed
the
poc/create_new_async_inline_error
branch
from
July 2, 2024 11:43
4c839d6
to
6294dd8
Compare
…age on async functions
kikoruiz
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Frontend Tech Community has agreed to create, use, and standardize the
@AsyncInlineError()
decorator. It will improve our code readability.This decorator catch-all method errors and each method instead of return a value, will return a tuple like
[error, response]
. So, with this decorator a method using it will never fail.On this PR, we provide:
@AsyncInlineError()
decorator@AsyncInlineError()
must be the first decorator in a method. It will make our life easier when we develop other decorators. The rule provide a quick fix.@AsyncInlineError()
should be used in all UseCase.execute, Service.execute and Repository.method. The rule will NOT provide a quick fix to avoid uncontrolled errors.Related Issue
Example
Client test ✅
Server test ✅