remove some opaque pointer dependencies #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleisui
reviewed
Dec 21, 2023
svf-llvm/lib/LLVMModule.cpp
Outdated
| @@ -1384,7 +1392,8 @@ SVFType* LLVMModuleSet::addSVFTypeInfo(const Type* T) | |||
| //cast svftype to SVFPointerType | |||
| SVFPointerType* svfPtrType = SVFUtil::dyn_cast<SVFPointerType>(svftype); | |||
| assert(svfPtrType && "this is not SVFPointerType"); | |||
| svfPtrType->setPtrElementType(getSVFType(LLVMUtil::getPtrElementType(pt))); | |||
| if(!pt->isOpaque()) | |||
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1295 +/- ##
==========================================
- Coverage 64.48% 64.45% -0.03%
==========================================
Files 223 223
Lines 23850 23870 +20
==========================================
+ Hits 15380 15386 +6
- Misses 8470 8484 +14
|
yuleisui
reviewed
Dec 21, 2023
svf-llvm/lib/LLVMModule.cpp
Outdated
| @@ -533,6 +533,14 @@ void LLVMModuleSet::loadModules(const std::vector<std::string> &moduleNameVec) | |||
|
|
|||
| owned_ctx = std::make_unique<LLVMContext>(); | |||
|
|
|||
| #if (LLVM_VERSION_MAJOR <= 14) | |||
yuleisui
reviewed
Dec 21, 2023
svf-llvm/lib/SVFIRBuilder.cpp
Outdated
| @@ -318,8 +318,12 @@ bool SVFIRBuilder::computeGepOffset(const User *V, AccessPath& ap) | |||
| // If it's a non-constant offset access | |||
| // If its point-to target is struct or array, it's likely an array accessing (%result = gep %struct.A* %a, i32 %non-const-index) | |||
| // If its point-to target is single value (pointer arithmetic), then it's a variant gep (%result = gep i8* %p, i32 %non-const-index) | |||
| if(!op && gepTy->isPointerTy() && getPtrElementType(SVFUtil::dyn_cast<PointerType>(gepTy))->isSingleValueType()) | |||
| isConst = false; | |||
| if(!op && gepTy->isPointerTy()) { | |||
There was a problem hiding this comment.
wrap up this as a function.
yuleisui
reviewed
Dec 21, 2023
svf-llvm/lib/SymbolTableBuilder.cpp
Outdated
| const Type* objtype = LLVMUtil::getPtrElementType(ptrType); | ||
| (void)getOrAddSVFTypeInfo(objtype); | ||
| // don't collect pointee type for opaque pointer | ||
| if(!ptrType->isOpaque()) { |
yuleisui
reviewed
Dec 21, 2023
svf/include/Util/Options.h
Outdated
| @@ -272,6 +272,8 @@ class Options | |||
| // Loop Analysis | |||
| static const Option<bool> LoopAnalysis; | |||
| static const Option<u32_t> LoopBound; | |||
|
|
|||
| static const Option<bool> DisableOpaquePointers; | |||
yuleisui
reviewed
Dec 21, 2023
| else if (const SVFPointerType* ptrOperandType = SVFUtil::dyn_cast<SVFPointerType>(idxOperandType)) | ||
| elemByteSize = ptrOperandType->getPtrElementType()->getByteSize(); | ||
| else if (SVFUtil::isa<SVFPointerType>(idxOperandType)) | ||
| elemByteSize = gep->getAccessPath().getGepPointeeType()->getByteSize(); |
There was a problem hiding this comment.
getGepPointeeType => gepSrcPointeeType
yuleisui
reviewed
Dec 21, 2023
svf/lib/SVFIR/SVFType.cpp
Outdated
Comment on lines
23
to
24
| if(isOpaque()) os << "ptr"; | ||
| else os << *ptrElementType << '*'; |
yuleisui
reviewed
Dec 21, 2023
svf/include/SVFIR/SVFType.h
Outdated
| @@ -368,10 +368,14 @@ class SVFPointerType : public SVFType | |||
| } | |||
| inline const SVFType* getPtrElementType() const | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove some opaque pointer dependencies