Converts a mangled name to C naming style to match functions in extapi.c #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1393 +/- ##
==========================================
- Coverage 67.83% 67.82% -0.01%
==========================================
Files 250 250
Lines 27632 27646 +14
==========================================
+ Hits 18743 18751 +8
- Misses 8889 8895 +6
|
yuleisui
reviewed
Mar 5, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| @@ -1062,7 +1062,7 @@ void LLVMModuleSet::buildFunToFunMap() | |||
| { | |||
| for (const Function* owfunc : overwriteExtFuncs) | |||
| { | |||
| if (appfunc->getName().str().compare(owfunc->getName().str()) == 0) | |||
| if (LLVMUtil::processMangledName(appfunc->getName().str()).compare(owfunc->getName().str()) == 0) | |||
There was a problem hiding this comment.
Promote this line to outer loop at 1063
yuleisui
reviewed
Mar 5, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| @@ -1040,7 +1040,7 @@ void LLVMModuleSet::buildFunToFunMap() | |||
| std::string declName = fdecl->getName().str(); | |||
| // Since C function names cannot include '.', change the function name from llvm.memcpy.p0i8.p0i8.i64 to llvm_memcpy_p0i8_p0i8_i64." | |||
| std::replace(declName.begin(), declName.end(), '.', '_'); | |||
| if (extfun->getName().str().compare(declName) == 0) | |||
| if (extfun->getName().str().compare(LLVMUtil::processMangledName(declName)) == 0) | |||
There was a problem hiding this comment.
Promote this to outer loop
yuleisui
reviewed
Mar 5, 2024
svf-llvm/lib/LLVMUtil.cpp
Outdated
| // First, remove all characters that do not conform to the C language naming rules. | ||
| std::string cleanedName = std::regex_replace(mangledName, std::regex("[^a-zA-Z0-9_]"), ""); | ||
| // Then, if the result starts with a number, remove these numbers. | ||
| cleanedName = std::regex_replace(cleanedName, std::regex("^\\d+"), ""); |
There was a problem hiding this comment.
Need to remove underline too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.