Add llvm-17.0.6 support #1422
Merged
Add llvm-17.0.6 support #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleisui
reviewed
Apr 2, 2024
| @@ -511,7 +510,7 @@ void LLVMUtil::removeFunAnnotations(Set<Function*>& removedFuncList) | |||
| glob->setName("llvm.global.annotations.old"); | |||
| GlobalVariable *GV = new GlobalVariable(newCA->getType(), glob->isConstant(), glob->getLinkage(), newCA, "llvm.global.annotations"); | |||
| GV->setSection(glob->getSection()); | |||
| module->getGlobalList().push_back(GV); | |||
| module->insertGlobalVariable(GV); | |||
There was a problem hiding this comment.
Thanks for the contribution. Could you add a macro for this?
#if (LLVM_VERSION_MAJOR < 17)
module->getGlobalList().push_back(GV);
#elif (LLVM_VERSION_MAJOR >= 17)
module->insertGlobalVariable(GV);
#else
assert(false && "llvm version not supported!");
#endif
There was a problem hiding this comment.
I added the macro.
adityavardhanpadala
force-pushed
the
master
branch
from
d14e6e9
to
3d23dbd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1422 +/- ##
==========================================
- Coverage 68.05% 68.04% -0.01%
==========================================
Files 250 250
Lines 27781 27780 -1
==========================================
- Hits 18905 18904 -1
Misses 8876 8876
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were only very few changes from llvm 16 to llvm 17
fixing these issues lets SVF build with llvm 17 and passes all the tests in the test suite.