fix: update verify process #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. |
Closed
JoursBleu
pushed a commit
to JoursBleu/EAGLE
that referenced
this pull request
Jun 28, 2024
fix: update verify process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the verification process needs another condition. According to the prove in SpecInfer, when all candidates in one draft candidate path are accepted, we need to sample the
sample_tokenfrom thelogitsof the last accepted node. Here, you still sample from thegtpand the last accepted token is also sampled fromgtp, which may cause repetition in the output. Here is what I got from your example.Please correct me if I misunderstood anything!