Add high-level boundary management interface #2177
Open
+503
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beryll1um
force-pushed
the
dev-router-boundary-management
branch
2 times, most recently
from
0d7c3e6
to
b611205
Compare
|
Still working on some minor improvements and bug fixes. I think this change requires better logging for closing outbound, but not all outbound implementations have a close method, which makes it a bit messy, so maybe we'll have to do the same thing we do on inbound to unify the outbound close interface and put the close log there. |
|
See examples in #2180! |
beryll1um
force-pushed
the
dev-router-boundary-management
branch
from
b611205
to
c945858
Compare
|
Revised few boundary mutex read lock places, and improved the structure of the Router interface and implementation. |
I rewrote the router's boundary management part to implement dynamic management from a high-level box interface. This also includes a number of changes I made in the process of rewriting some messy parts, such as the Outbound tree bottom-top starter.
beryll1um
force-pushed
the
dev-router-boundary-management
branch
from
c945858
to
f25cb7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the router's boundary management part to implement dynamic management from a high-level box interface. This also includes a number of changes I made in the process of rewriting some messy parts, such as the Outbound tree bottom-top starter.
What I reallly need is someone how is experianced in this project (like @nekohasekai) to check my changes and verify everything good and I didn't forget anything. I'm planning to run my project on it, so wait for more improvements in the future =)