Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WDEFAULT_ARGS #11

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Fix WDEFAULT_ARGS #11

merged 1 commit into from
Sep 17, 2019

Conversation

Misiu
Copy link
Contributor

@Misiu Misiu commented Sep 17, 2019

Also please consider releasing releases, this way we can refer Your action using version instead of using @master. This way potential bugs won't break working FTP deploy

@SamKirkland SamKirkland merged commit b4e9e0a into SamKirkland:master Sep 17, 2019
@Misiu Misiu deleted the patch-1 branch September 17, 2019 13:12
@SamKirkland
Copy link
Owner

Thanks for the fix.

I actually do use releases, they just aren't documented well (i'll update the readme).
I incorrectly thought I had tested this change well enough for it to be non-breaking ☹️

@Misiu
Copy link
Contributor Author

Misiu commented Sep 18, 2019

@SamKirkland no worries 🙂 as Roosevelt said:

The only man who makes no mistakes is the man who never does anything.

Don't worry and keep up the good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants