-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Turing through imports #123
Conversation
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 7 7
Lines 238 238
=======================================
Hits 217 217
Misses 21 21
Continue to review full report at Codecov.
|
Will require new release of AdvancedHMC TuringLang/AdvancedHMC.jl#160, once it's in this should be good to go. Works for me locally. |
The new release is there. |
Thanks @xukai92! |
@xukai92 can we get some help figuring out what Turing is trying to iterate? |
Do you mean why we do this DynamicPPL thing? |
@ChrisRackauckas that happens because https://github.com/TuringLang/Turing.jl/blob/master/src/inference/Inference.jl#L856's types, the |
It's might be related to what @mohamed82008 is trying to fix. |
Yes that looks related to TuringLang/Turing.jl#1043. I will take a look next week. Please open an issue in Turing to track it, happy to investigate when I get some time. |
No description provided.