CompatHelper: bump compat for "Turing" to "0.17" #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ChrisRackauckas
force-pushed
the
compathelper/new_version/2021-08-06-01-09-15-696-961379642
branch
from
7227203
to
5a4bdc9
Compare
|
@devmotion something seems to have increased the run time by quite a lot such that the CI's not able to finish since Turing >=v0.16.6 do you happen to know what could be the reason? |
Vaibhavdixit02
deleted the
compathelper/new_version/2021-08-06-01-09-15-696-961379642
branch
|
Might be JuliaStats/Distributions.jl#1362, I know that it caused test time regressions in Turing since deprecation warnings are enabled at test time. However, since they are disabled by default if you use |
|
It was an issue here as well, probably since we load Distributions separately, anyway it got handled since I found the discussion in Turing. Thanks for the follow up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Turingpackage from0.12, 0.13, 0.14, 0.15, 0.16to0.12, 0.13, 0.14, 0.15, 0.16, 0.17.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.