Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple initial conditions, replicates, and partial pooling. #327

Closed
wants to merge 6 commits into from

Conversation

saumil-sh
Copy link
Contributor

@saumil-sh saumil-sh commented Feb 28, 2024

Hey,
I use turing_interface from this package in my project. I could extend the turing_interface to accept multiple initial conditions and replicate (in case of experimental and measured data) for the same ODE system (complete pooling). Some statistical modeling feature partial pooling of inferred parameters, and this extension was also possible.

I made the rookie mistake of upgrading my Julia to v1.10 without considering the consequences. This led to many packages failing on precompile. I managed to hack my way around this by removing the compact. I know this is not ideal.

I am writing a test for this now, and I will also update the documentation at the appropriate places. I don't have stan installed at the moment, so I can't fix failing stan tests at the moment.

Meanwhile, can someone please tell me whether this is a useful and good way to implement the features?

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@saumil-sh
Copy link
Contributor Author

I realized I am trying to achieve too many things within this pull request, including updating compat to Julia v1.10 and MTK v9. The functionality I want to add has nothing to do with these two. So, I will create a couple of pull requests that are more minimal and modular.

@saumil-sh saumil-sh closed this Feb 28, 2024
@ChrisRackauckas
Copy link
Member

Awesome, I was going to say that will be needed since there's a ton going on here. Indeed splitting the PR will help with the updating and review a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants