Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ABC inference using ApproxBayes.jl #38

Closed

Conversation

marcjwilliams1
Copy link
Contributor

Initial version of abc_inference which uses the ApproxBayes package to do Approximate Bayesian Computation inference.

@ChrisRackauckas
Copy link
Member

It looks like the PR is missing src/abc_inference.jl and test/abc.jl?

@marcjwilliams1
Copy link
Contributor Author

Sorry, I've managed to make a new PR rather than add it here. How do I do that properly? I did PkgDev.submit("DiffEqBayes") again

@ChrisRackauckas
Copy link
Member

PkgDev.submit is not for submitting PRs to repositories. It's for submitting tags to METADATA.jl. Here's a video that shows how to do this package dev stuff:

https://www.youtube.com/watch?v=tx8DRc7_c9I

@marcjwilliams1
Copy link
Contributor Author

Thanks, I'll take a look at the video.

I followed what was outlined in the code changes section in the julia docs: https://docs.julialang.org/en/stable/manual/packages/#Packages-1

@ChrisRackauckas
Copy link
Member

That page is for the package manager and submitting packages to the METADATA.jl registry, but not for actually working on packages themselves.

@marcjwilliams1
Copy link
Contributor Author

ok fair enough, seems a bit confusing to me then. I imagine others might think similarly, ie this is pasted from the docs

Here we assume you've already set up git on your local machine and have a GitHub account (see above). Let's imagine you're fixing a bug in the Images package:

Pkg.checkout("Images")           # check out the master branch
<here, make sure your bug is still a bug and hasn't been fixed already>
cd(Pkg.dir("Images"))
;git checkout -b myfixes         # create a branch for your changes
<edit code>                      # be sure to add a test for your bug
Pkg.test("Images")               # make sure everything works now
;git commit -a -m "Fix foo by calling bar"   # write a descriptive message
using PkgDev
PkgDev.submit("Images")

The last line will present you with a link to submit a pull request to incorporate your changes.

@marcjwilliams1
Copy link
Contributor Author

anyway, thanks for the video, I'll follow that procedure in future

@ChrisRackauckas
Copy link
Member

The last line will present you with a link to submit a pull request to incorporate your changes.

To incorporate your changes into METADATA.jl.

https://github.com/JuliaLang/METADATA.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants