Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made dynamichmc_inference more versatile: choice of alg, kwargs #41

Merged
merged 1 commit into from
May 2, 2018

Conversation

mauro3
Copy link
Contributor

@mauro3 mauro3 commented May 2, 2018

This adds the ability to pass the alg and solver kwargs to dynamichmc_inference. It also re-ordered its arguments to mirror those of turing_inference.

@mauro3 mauro3 changed the title Made dynamichmc_inference more versatile: choise of alg, kwargs Made dynamichmc_inference more versatile: choice of alg, kwargs May 2, 2018
@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #41 into master will decrease coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   89.58%   89.16%   -0.42%     
==========================================
  Files           6        6              
  Lines         240      240              
==========================================
- Hits          215      214       -1     
- Misses         25       26       +1
Impacted Files Coverage Δ
src/dynamichmc_inference.jl 94.28% <100%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec9405...0d1c66e. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit ecc1fa5 into SciML:master May 2, 2018
@ChrisRackauckas
Copy link
Member

Thanks! Yes, this needed to be done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants