Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes non ISTP compliant files axis merging #109

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Nov 5, 2023

Some files uses DEPEND_TIME instead of DEPEND_0 to point to time axis. This was supported by speasy for data variables but not for support variables.

Some files uses DEPEND_TIME instead of DEPEND_0 to point to time axis.
This was supported by speasy for data variables but not for support variables.

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet added the bug Something isn't working label Nov 5, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6730069) 86.30% compared to head (e18a37f) 87.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   86.30%   87.41%   +1.10%     
==========================================
  Files          51       51              
  Lines        3052     3058       +6     
  Branches      474      497      +23     
==========================================
+ Hits         2634     2673      +39     
+ Misses        277      249      -28     
+ Partials      141      136       -5     
Flag Coverage Δ
unittests 86.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
speasy/core/cdf/__init__.py 76.78% <100.00%> (+1.31%) ⬆️
speasy/webservices/generic_archive/__init__.py 89.70% <100.00%> (+0.15%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeandet jeandet merged commit 37cfaee into SciQLop:main Nov 5, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant