-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed amda multidimensional data download, column names #25
Conversation
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 86.55% 85.34% -1.21%
==========================================
Files 31 31
Lines 1450 1467 +17
Branches 207 209 +2
==========================================
- Hits 1255 1252 -3
- Misses 133 153 +20
Partials 62 62
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Can you add a test here https://github.com/SciQLop/speasy/blob/main/tests/test_amda.py#L53 ? I feel like we could easily forget this and introduce some regressions later. |
will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, THX.
…mes) Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Small fix for downloading multidimensional data from AMDA