Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed amda multidimensional data download, column names #25

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

Dolgalad
Copy link
Contributor

Small fix for downloading multidimensional data from AMDA

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #25 (b1b0b91) into main (78fa1b9) will decrease coverage by 1.20%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   86.55%   85.34%   -1.21%     
==========================================
  Files          31       31              
  Lines        1450     1467      +17     
  Branches      207      209       +2     
==========================================
- Hits         1255     1252       -3     
- Misses        133      153      +20     
  Partials       62       62              
Flag Coverage Δ
unittests 85.34% <96.66%> (-1.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
speasy/webservices/amda/ws.py 86.20% <80.00%> (-1.99%) ⬇️
speasy/core/__init__.py 95.00% <100.00%> (+2.14%) ⬆️
speasy/core/cache/__init__.py 88.23% <100.00%> (+0.07%) ⬆️
speasy/core/proxy/__init__.py 91.17% <100.00%> (+0.26%) ⬆️
speasy/webservices/amda/utils.py 87.69% <100.00%> (ø)
speasy/webservices/cda/__init__.py 46.53% <100.00%> (+0.53%) ⬆️
speasy/webservices/ssc/__init__.py 88.05% <100.00%> (+0.18%) ⬆️
speasy/webservices/amda/_impl.py 72.04% <0.00%> (-13.98%) ⬇️
speasy/webservices/amda/rest_client.py 75.28% <0.00%> (-6.75%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ea87f...b1b0b91. Read the comment docs.

@jeandet
Copy link
Member

jeandet commented Nov 24, 2021

Can you add a test here https://github.com/SciQLop/speasy/blob/main/tests/test_amda.py#L53 ? I feel like we could easily forget this and introduce some regressions later.

@jeandet jeandet self-requested a review November 24, 2021 16:42
@jeandet jeandet added the bug Something isn't working label Nov 24, 2021
@jeandet jeandet added this to the v1.0.0 milestone Nov 24, 2021
@Dolgalad
Copy link
Contributor Author

Can you add a test here https://github.com/SciQLop/speasy/blob/main/tests/test_amda.py#L53 ? I feel like we could easily forget this and introduce some regressions later.

will do

Copy link
Member

@jeandet jeandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, THX.

@jeandet jeandet merged commit 27b9e6c into SciQLop:main Nov 25, 2021
jeandet added a commit that referenced this pull request Nov 25, 2021
…mes)

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants