Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Check that each push or PR doesn't break release process #34

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Feb 3, 2022

While releasing 0.10.0, I discovered that I broke title consistency between README and HISTORY which are used for generating PyPi landing page.
To avoid this, I propose to generate python packages on each push and PR and just run twine check to ensure everything still works.

@jeandet jeandet requested a review from Dolgalad February 3, 2022 12:07
@jeandet jeandet added the enhancement New feature or request label Feb 3, 2022
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #34 (5bc35fe) into main (038c88a) will decrease coverage by 1.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   87.10%   85.54%   -1.57%     
==========================================
  Files          31       31              
  Lines        1474     1474              
  Branches      248      248              
==========================================
- Hits         1284     1261      -23     
- Misses        127      150      +23     
  Partials       63       63              
Flag Coverage Δ
unittests 85.54% <ø> (-1.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
speasy/webservices/amda/_impl.py 72.04% <0.00%> (-13.98%) ⬇️
speasy/webservices/amda/rest_client.py 75.55% <0.00%> (-6.67%) ⬇️
speasy/core/__init__.py 95.00% <0.00%> (-2.50%) ⬇️
speasy/webservices/amda/ws.py 86.39% <0.00%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038c88a...5bc35fe. Read the comment docs.

@nicolasaunai nicolasaunai requested review from Dolgalad and removed request for Dolgalad February 4, 2022 19:49
@jeandet jeandet merged commit 36c3b16 into SciQLop:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants